[None][chore] Add failed cases into waives.txt by xinhe-nv · Pull Request #10365 · NVIDIA/TensorRT-LLM

xinhe-nv · 2025-12-31T14:09:47Z

waive failed cases.

Summary by CodeRabbit

Tests
- Updated test skip configuration for specific test scenarios.

Note: This release contains internal testing infrastructure updates with no user-facing changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

jieli-matrix · 2026-01-06T09:24:51Z

/bot run --stage-list ""

coderabbitai · 2026-01-06T09:24:54Z

📝 Walkthrough

Walkthrough

Two test cases are added to the waives skip list: TestLlama3_2_1B::test_fp8_prequantized and TestMinistral8BInstruct::test_fp8 from the LLM API PyTorch accuracy tests. No logic or behavioral changes are introduced.

Changes

Cohort / File(s)	Summary
Test Waives Configuration `tests/integration/test_lists/waives.txt`	Added two SKIP entries: `accuracy/test_llm_api_pytorch.py::TestLlama3_2_1B::test_fp8_prequantized` and `accuracy/test_llm_api_pytorch.py::TestMinistral8BInstruct::test_fp8`

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

[None][chore] Add failed cases into waives.txt #10177: Modifies the same waives.txt file by adding SKIP entries for failing tests.
[None][chore] Add failed cases into waives.txt #10025: Updates waives.txt with additional SKIP entries to waive failing tests.
[None][chore] Add failed cases into waives.txt #10321: Adds SKIP entries to waives.txt for failing test cases.

Suggested reviewers

crazydemo
LarryXFly
yingguo-trt

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is incomplete. It lacks the required sections: Description (explaining the issue and solution), Test Coverage (listing relevant tests), and PR Checklist (verification items).	Add comprehensive Description section explaining why these test cases are being waived, include Test Coverage section listing the waived tests, and complete the PR Checklist items.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: adding failed test cases to the waives.txt file, following the proper format with ticket type [None][chore].
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6507087 and 1f6ef52.

📒 Files selected for processing (1)

tests/integration/test_lists/waives.txt

🧰 Additional context used

🧠 Learnings (8)

📓 Common learnings

Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

📚 Learning: 2025-09-17T02:48:52.732Z

Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

tests/integration/test_lists/waives.txt

📚 Learning: 2025-09-09T09:40:45.658Z

Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

tests/integration/test_lists/waives.txt

📚 Learning: 2025-08-29T14:07:45.863Z

Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

tests/integration/test_lists/waives.txt

📚 Learning: 2025-07-22T08:33:49.109Z

Learnt from: yiqingy0
Repo: NVIDIA/TensorRT-LLM PR: 5198
File: jenkins/mergeWaiveList.py:0-0
Timestamp: 2025-07-22T08:33:49.109Z
Learning: In the TensorRT-LLM waive list merging system, removed lines are always located at the end of the merge waive lists, which is why the mergeWaiveList.py script uses reverse traversal - it's an optimization for this specific domain constraint.

Applied to files:

tests/integration/test_lists/waives.txt

📚 Learning: 2025-08-26T09:49:04.956Z

Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

tests/integration/test_lists/waives.txt

📚 Learning: 2025-07-28T17:06:08.621Z

Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

tests/integration/test_lists/waives.txt

📚 Learning: 2025-08-06T13:58:07.506Z

Learnt from: galagam
Repo: NVIDIA/TensorRT-LLM PR: 6487
File: tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py:1-12
Timestamp: 2025-08-06T13:58:07.506Z
Learning: In TensorRT-LLM, test files (files under tests/ directories) do not require NVIDIA copyright headers, unlike production source code files. Test files typically start directly with imports, docstrings, or code.

Applied to files:

tests/integration/test_lists/waives.txt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

🔇 Additional comments (1)

tests/integration/test_lists/waives.txt (1)

494-495: LGTM—straightforward test waiver additions.

Both new entries are correctly formatted and follow the established pattern in the file (test path, class, method, SKIP keyword, and bug reference). The additions align with the PR objective and commit messages describing updates to the waive list.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2026-01-06T09:31:01Z

PR_Github #30723 [ run ] triggered by Bot. Commit: 1f6ef52

tensorrt-cicd · 2026-01-06T11:50:54Z

PR_Github #30723 [ run ] completed with state SUCCESS. Commit: 1f6ef52
/LLM/main/L0_MergeRequest_PR pipeline #23706 (Partly Tested) completed with status: 'SUCCESS'

Signed-off-by: Jie Li <lijie@nvidia.com>

jieli-matrix · 2026-01-07T02:22:00Z

/bot reuse-pipeline

tensorrt-cicd · 2026-01-07T02:27:58Z

PR_Github #30809 [ reuse-pipeline ] triggered by Bot. Commit: e94b905

tensorrt-cicd · 2026-01-07T03:07:49Z

PR_Github #30809 [ reuse-pipeline ] completed with state SUCCESS. Commit: e94b905
Reusing PR_Github #30723 (Partly Tested) for commit e94b905

Signed-off-by: xinhe-nv <200704525+xinhe-nv@users.noreply.github.com> Signed-off-by: Jie Li <lijie@nvidia.com> Signed-off-by: Jie Li <76780849+jieli-matrix@users.noreply.github.com> Co-authored-by: Jie Li <lijie@nvidia.com> Co-authored-by: Jie Li <76780849+jieli-matrix@users.noreply.github.com> Signed-off-by: Daniil Kulko <kulkodaniil@gmail.com>

xinhe-nv requested review from LarryXFly and crazydemo December 31, 2025 14:09

jieli-matrix self-assigned this Jan 6, 2026

jieli-matrix marked this pull request as ready for review January 6, 2026 09:22

jieli-matrix enabled auto-merge (squash) January 6, 2026 09:25

LarryXFly approved these changes Jan 6, 2026

View reviewed changes

jieli-matrix force-pushed the user/qa/post_update_waive_20251231_LLM_FUNCTION_TEST_1799 branch from 1f6ef52 to 2116c88 Compare January 7, 2026 02:20

update acc cases

e94b905

Signed-off-by: Jie Li <lijie@nvidia.com>

jieli-matrix force-pushed the user/qa/post_update_waive_20251231_LLM_FUNCTION_TEST_1799 branch from 2116c88 to e94b905 Compare January 7, 2026 02:21

jieli-matrix merged commit 1fbadd2 into NVIDIA:main Jan 7, 2026
5 checks passed

xinhe-nv deleted the user/qa/post_update_waive_20251231_LLM_FUNCTION_TEST_1799 branch January 20, 2026 08:26

coderabbitai bot mentioned this pull request Jan 29, 2026

[None][chore] Add failed cases into waives.txt #10992

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[None][chore] Add failed cases into waives.txt#10365

[None][chore] Add failed cases into waives.txt#10365
jieli-matrix merged 1 commit intoNVIDIA:mainfrom
xinhe-nv:user/qa/post_update_waive_20251231_LLM_FUNCTION_TEST_1799

xinhe-nv commented Dec 31, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

jieli-matrix commented Jan 6, 2026

Uh oh!

coderabbitai bot commented Jan 6, 2026

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

tensorrt-cicd commented Jan 6, 2026

Uh oh!

tensorrt-cicd commented Jan 6, 2026

Uh oh!

jieli-matrix commented Jan 7, 2026

Uh oh!

tensorrt-cicd commented Jan 7, 2026

Uh oh!

tensorrt-cicd commented Jan 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

xinhe-nv commented Dec 31, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

jieli-matrix commented Jan 6, 2026

Uh oh!

coderabbitai bot commented Jan 6, 2026

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Pre-merge checks

Uh oh!

tensorrt-cicd commented Jan 6, 2026

Uh oh!

tensorrt-cicd commented Jan 6, 2026

Uh oh!

jieli-matrix commented Jan 7, 2026

Uh oh!

tensorrt-cicd commented Jan 7, 2026

Uh oh!

tensorrt-cicd commented Jan 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xinhe-nv commented Dec 31, 2025 •

edited by coderabbitai bot

Loading